Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Support loading of examples table with associated properties

Description

data.table

col1

col2

col3

col4

.....

data

data

data

data

data

data

data

data

data

data

data

data

......
scenarios
Scanario: Handle input one way
When I do something with the data from example table
Examples:
{transformer=TRANSFORM_1}
/tables/data.table

Scanario: Handle input second way
When I do something with the data from example table
Examples:
{transformer=TRANSFORM_2}
/tables/data.table

So basically we have one dataset that we want to transform in different ways, current implementation doesn't allow to use params and table in the previously shown way, as a parsing output we get parsed parameters and the path to the table without loading it.

Expected result: parameters are parsed and table is loaded

Activity

Show:

Uladzislau Arlouski April 1, 2020 at 9:47 AM

Hi ,

Thanks for the response, I’ll notify you once the checking is done

Thanks

Mauro Talevi March 21, 2020 at 6:44 PM

Hi Uladzislau, I’ve refactored TableUtils containing static parsing methods to become an injectable class TableParsers with non-static methods.

In general, I tend to live by the mantra that static is evil and that it’s preferable to have logic incapsulated by injectable classes.

Please check it all works for you and feel free to propose other improvements, if needed.

Thanks

Uladzislau Arlouski March 18, 2020 at 10:39 AM

Hi ,

Refactored as requested, please review https://github.com/jbehave/jbehave-core/pull/267/files

Thanks

Mauro Talevi March 17, 2020 at 10:33 PM

Hi Uladzislau, would you mind refactoring the ExamplesTableData/Properties classes to be inner (static) classes of ExamplesTable?

Uladzislau Arlouski March 15, 2020 at 9:15 AM

Hi ,

Please review https://github.com/jbehave/jbehave-core/pull/267

Thanks

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created March 14, 2020 at 12:19 PM
Updated April 5, 2020 at 1:24 PM
Resolved April 5, 2020 at 1:17 PM

Flag notifications