Add missing reporting of dry run

Description

For execution tests using dry run needs to update PerformableTree class.

Activity

Show:

Mauro Talevi May 3, 2019 at 3:53 PM

Pulled with thanks

Alena Budevich May 3, 2019 at 6:43 AM

Hi ,

I've fixed the test and created a new PR, could you please take a look https://github.com/jbehave/jbehave-core/pull/236/files ?

Thanks

Mauro Talevi April 28, 2019 at 7:57 PM

Could you please review failing test:

java.lang.NullPointerException
at org.jbehave.core.embedder.PerformableTree$PerformableSteps.add(PerformableTree.java:1198)
at org.jbehave.core.embedder.PerformableTree$AbstractPerformableScenario.addBeforeSteps(PerformableTree.java:1064)
at org.jbehave.core.embedder.PerformableTree.addStepsWithLifecycle(PerformableTree.java:227)
at org.jbehave.core.embedder.PerformableTree.normalScenario(PerformableTree.java:192)
at org.jbehave.core.embedder.PerformableTree.performableScenario(PerformableTree.java:148)
at org.jbehave.core.embedder.PerformableTree.performableStory(PerformableTree.java:103)
at org.jbehave.core.embedder.PerformableTree.addStories(PerformableTree.java:70)
at org.jbehave.core.embedder.PerformableTreeBehaviour.performStoryIfDryRunTrue(PerformableTreeBehaviour.java:143)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)

Alena Budevich February 28, 2019 at 3:02 PM
Edited

Hi ,

Could you please review the pull request: https://github.com/jbehave/jbehave-core/pull/229 ?
Thanks

Fixed

Details

Assignee

Reporter

Fix versions

Priority

Created February 28, 2019 at 2:56 PM
Updated May 3, 2019 at 3:53 PM
Resolved May 3, 2019 at 3:53 PM