NumberConverter should not ignore all non digit characters for BigDecimal type
Description
Activity
Show:
Fixed
Details
Details
Details
Created August 4, 2015 at 11:47 AM
Updated August 5, 2015 at 6:43 AM
Resolved August 5, 2015 at 6:43 AM
Atlassian uses cookies to improve your browsing experience, perform analytics and research, and conduct advertising. Accept all cookies to indicate that you agree to our use of cookies on your device. Atlassian cookies and tracking notice, (opens new window)
NumberConverter allow values like 'HelloWorld123' to be converter into 123 as BigDecimal. This can lead into wrong data, without user noticing.
There are some non digit characters like dot ('.') and comma (',') that we should allow, in order to ease reading of big numbers like:
1.000.000,12 or 1,000,000.12 depending on the Locale.
https://github.com/rjimgal/jbehave-bigdecimal-converter project demonstrates how '0x1A' is converted into BigDecimal 1, while one could expect NumberConverter to support hex inputs.